Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the process start time #7214

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

singh264
Copy link
Contributor

Get the process start time on linux, windows, osx, aix and
z/os.

Issue: #7201
Signed-off-by: Amarpreet Singh [email protected]

@babsingh
Copy link
Contributor

jenkins build all

@singh264
Copy link
Contributor Author

singh264 commented Jan 2, 2024

@singh264
Copy link
Contributor Author

singh264 commented Jan 2, 2024

@tajila requesting your review.

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review. Will do a thorough review once @tajila confirms that this implementation meets the requirements for #7201.

fvtest/porttest/si.cpp Show resolved Hide resolved
fvtest/porttest/si.cpp Show resolved Hide resolved
port/win32/omrsysinfo.c Outdated Show resolved Hide resolved
port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
port/common/omrsysinfo.c Outdated Show resolved Hide resolved
port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
port/win32/omrsysinfo.c Outdated Show resolved Hide resolved
port/zos390/omrintrospect.h Outdated Show resolved Hide resolved
port/zos390/omrintrospect.h Outdated Show resolved Hide resolved
@tajila
Copy link
Contributor

tajila commented Jan 3, 2024

@singh264
Copy link
Contributor Author

singh264 commented Jan 5, 2024

@singh264
Copy link
Contributor Author

singh264 commented Jan 5, 2024

@babsingh re-requesting your review.

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the comments which have been addressed.

fvtest/porttest/si.cpp Outdated Show resolved Hide resolved
fvtest/porttest/si.cpp Show resolved Hide resolved
port/aix/omrtime.c Outdated Show resolved Hide resolved
port/common/omrport.tdf Outdated Show resolved Hide resolved
port/common/omrport.tdf Outdated Show resolved Hide resolved
port/common/omrsysinfo.c Outdated Show resolved Hide resolved
port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
port/unix/omrsysinfo.c Show resolved Hide resolved
port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
@singh264 singh264 force-pushed the omr_issues_7201 branch 3 times, most recently from 403d584 to 4849c60 Compare January 8, 2024 21:52
@singh264
Copy link
Contributor Author

@singh264
Copy link
Contributor Author

@babsingh re-requesting your review.

port/unix/omrsysinfo.c Outdated Show resolved Hide resolved
port/win32/omrsysinfo.c Outdated Show resolved Hide resolved
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse-omr#7201
Signed-off-by: Amarpreet Singh <[email protected]>
@singh264
Copy link
Contributor Author

@singh264
Copy link
Contributor Author

@babsingh re-requesting your review.

@babsingh
Copy link
Contributor

jenkins build all

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babsingh babsingh merged commit 9d24613 into eclipse-omr:master Jan 11, 2024
15 of 18 checks passed
singh264 added a commit to singh264/openj9 that referenced this pull request Jan 24, 2024
Get the start time of the criu restore process, which is
the parent process of the restored java process.

Issue: eclipse-openj9#18598
Depends-on: eclipse-omr/omr#7214
Signed-off-by: Amarpreet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants