Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Add Store Update #14

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add Store Update #14

wants to merge 18 commits into from

Conversation

berezovskyi
Copy link
Contributor

@berezovskyi berezovskyi commented Sep 2, 2017

This patch is moved from Gerrit Change 95016.

FIxes #3


@jadelkhoury
Copy link
Contributor

Code looks good to me.
The readme.md file is the same as the Store-core?
It would have been nice otherwise with some explanations of the main classes (oslcMessage, Handler, ChangeProvider). Alternatively, a very simple documentation of how it all fits together could be nice.

@jadelkhoury
Copy link
Contributor

+1 for review

@berezovskyi
Copy link
Contributor Author

@jamsden did you have time to look at this?

This patch adds all the remaing "boxes" from the architecture depicted here: https://github.com/eclipse/lyo-store/blob/cb11ca9fd9c01c817b3554e7f197d84f788e8b64/src/store-update/doc/architecture.png: change provider, update manager, and handlers.

Closes #22

Signed-off-by: Andrew Berezovskyi <[email protected]>
This patch is moved from Gerrit Change 95016.

Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
This patch is moved from Gerrit Change 95016.

Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
* Add both EPL and EDL licenses
* Rename artefacts in POMs
* Rebase on top of the Jena 3.6.0 move

Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
@berezovskyi
Copy link
Contributor Author

I think we should replace my handmade pub-sub mechanism with http://www.baeldung.com/guava-eventbus if it is able to fulfill all our needs.

Copy link

@jamsden jamsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had any time to do anything with this yet.

@berezovskyi berezovskyi added this to the 4.0.0 milestone Nov 13, 2018
# Conflicts:
#	src/pom.xml
#	src/store-core/.gitignore
#	src/store-core/pom.xml
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
@berezovskyi
Copy link
Contributor Author

@jadelkhoury @jamsden shall we add it to the 4.0 release?

@berezovskyi
Copy link
Contributor Author

@jadelkhoury @jamsden I hit a snag with the earlier breaking API change where we split TRS log interaction interface in two: PagedTrs and TrsEventHandler. The latter now requires a Resource to be supplied when it is added/modified/deleted. TRS Sync Handler only has metadata. For now, I have extracted TRS handlers from store-sync into store-sync-trs and disabled the module from the build/deploy.

@berezovskyi berezovskyi removed the request for review from yashkhatri November 9, 2020 22:56
@jadelkhoury
Copy link
Contributor

This PR from 2017. I no longer have any ideas what it is about. What's TRS stuff doing under Store?

@berezovskyi
Copy link
Contributor Author

berezovskyi commented Nov 9, 2020

This PR from 2017. I no longer have any ideas what it is about.

Yes, my memory has faded a bit too. But I think it's about having Store being a cache in front of a non-OSLC app, synchronising the data without making N requests to the API for N requests to the OSLC endpoint. But it was too long ago.

What's TRS stuff doing under Store?

That's one of the few things I can explain clearly: when a resource is added/modified/deleted through Lyo Store, we add it automatically to the TRS log without having you manually edit it (the log).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribute Lyo store update library
4 participants