Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to remove jakarta.annotation-api #3809

Merged

Conversation

nicolatimeus
Copy link
Contributor

@nicolatimeus nicolatimeus commented Feb 21, 2022

Signed-off-by: Nicola Timeus [email protected]

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

The packages provided by jakarta.annotation-api (javax.annotation, javax.annotation.security and javax.annotation.sql) are already provided by com.eclipsesource.jaxrs.jersey-min.

@MMaiero MMaiero merged commit 5215116 into eclipse-kura:develop Feb 23, 2022
@spnettec
Copy link
Contributor

com.eclipsesource.jaxrs.jersey-min is too old

@nicolatimeus
Copy link
Contributor Author

We have removed this because having both com.eclipsesource.jaxrs.jersey-min and the Jakarta bundle leads to this issue: hstaudacher/osgi-jax-rs-connector#194 (comment).
Are you having problems with the version of the APIs in the jersey-min bundle?
Removing the Jakarta bundle is not an ideal solution but since we are close to 5.1 release we applied this change with the idea of finding a better solution in the next release cycle.
If you have a better solution ready please open a PR!

@nicolatimeus nicolatimeus deleted the enh_remove-jakarta-annotation branch March 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants