feat: provide completion for Resource Bundle keys#3598
Draft
fbricon wants to merge 1 commit intoeclipse-jdtls:mainfrom
Draft
feat: provide completion for Resource Bundle keys#3598fbricon wants to merge 1 commit intoeclipse-jdtls:mainfrom
fbricon wants to merge 1 commit intoeclipse-jdtls:mainfrom
Conversation
datho7561
approved these changes
Jan 19, 2026
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Works pretty good!
Completions are still suggested at the second argument, eg.
bundle.getString("my.first.translation", /* here */);Annoying but not a deal breaker IMO.
If I hardcode a locale, the completion details still show the value from the bundle without the locale. I guess this behaviour makes sense, since the locale is usually dynamic instead of hardcoded.
Contributor
Author
|
Adding support to the locale, I had to throw away a lot of code to change my approach. I'm getting there. |
Signed-off-by: Fred Bricon <fbricon@gmail.com>
67e9431 to
18e3df7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #881
Known limitations:
Opens the door to more potential enhancements
Signed-off-by: Fred Bricon fbricon@gmail.com