Add config_unix directory to release archives for BSD/Unix compatibility#3594
Open
rpx99 wants to merge 2 commits intoeclipse-jdtls:mainfrom
Open
Add config_unix directory to release archives for BSD/Unix compatibility#3594rpx99 wants to merge 2 commits intoeclipse-jdtls:mainfrom
rpx99 wants to merge 2 commits intoeclipse-jdtls:mainfrom
Conversation
Many users, especially on BSD systems, use config_unix in their startup scripts instead of config_linux. This change adds config_unix as a copy of config_linux to the release archive, preventing "config.ini not found" errors on these systems. Changes: - Added maven execution to copy config_unix from Linux x86_64 configuration - Added config_unix to publish-assembly.xml for inclusion in release archives Fixes compatibility with BSD systems and scripts expecting config_unix.
Extended the previous commit to also include config_unix_arm for ARM64 systems, maintaining architectural parity with the existing config_linux and config_linux_arm structure. Changes: - Added copy-config-unix-arm execution to pom.xml for ARM64 configuration - Added config_unix_arm to publish-assembly.xml This ensures both x86_64 and aarch64 BSD/Unix systems are properly supported with their respective configurations.
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Is it a "just in case", hypothetical need or do you actually need this change? |
Author
|
@fbricon Well, i am on Unix and the folder is empty, which i did not expect. I can copy over from linux folder, but it's an inconsistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
config_unixdirectory to release archives as an alias forconfig_linuxconfiguration, improving compatibility with BSD systems and custom launcher scripts.Problem
Some users, particularly on BSD systems, expect a
config_unixdirectory in their startup scripts rather thanconfig_linux. While the officialjdtls.pylauncher maps FreeBSD toconfig_linux, custom launcher scripts and community tools may assumeconfig_unixexists, leading to "config.ini not found" errors.Solution
This PR adds
config_unixas a copy of the Linux x86_64 configuration during the Maven build process. The content is identical toconfig_linux- this is purely an alias for better compatibility.Changes Made
org.eclipse.jdt.ls.product/pom.xml:
copy-config-unixexecution in maven-resources-pluginconfig_unixdirectory during package phaseorg.eclipse.jdt.ls.product/publish-assembly.xml:
config_unix/**to the list of included directories in release archivesBenefits
config_unixconfig_linuxcontinue to workTesting
The next full build will include
config_unixin the release archives alongside the existingconfig_linux,config_mac, andconfig_windirectories.