Add tests for type hierarchy with subtype in lambda #4710
+253
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The working copy test fails with: |
Contributor
Author
|
I've adjusted the new tests to also run into the problem seen in #4704. The two fails are now: (#4704) (#4707) |
trancexpress
force-pushed
the
gh4707
branch
2 times, most recently
from
82665bb to
07ddcac
Compare
Contributor
Author
|
When I check how the other types in the computed hierarchy are found in For The cache has a corresponding Both have For the anonymous type in the lambda, the hierarchy als contains a
This leads to calling
The The The Note that I also see this From what I can tell, the (expected) This The unexpected In
But at |
Contributor
Author
|
This highlights the difference and why we don't find the anonymous type in the types created on Output: Note that if I traverse |
Contributor
Author
|
@stephan-herrmann could you give your opinion here? I have those two classes: What do you think should be the parent of the anonymous type in
If I would replace the lambda declaration with an anonymous subtype of But with the lambda I don't know. And without knowing, I'm not sure in which code I should be analyzing the problem further. |
Contributor
With "parent" you mean the enclosing IJavaElement? (I'm asking because in the context of type hierarchies the term "parent" could mean "super type"). I vaguely recall that integrating Some quick ideas from afar:
|
Contributor
Author
The object returned by
Not that I see, actually the
No, I don't see any on the stack trace. Unless I missed anything; but I think everything is computed on-the-fly. Especially with the code in the new tests.
What the hierarchy code has as parents of the local type is: The lambda itself is also a parent here. Neither the lambda nor Alright, I'll keep looking at this code then: I think |
Contributor
Author
|
Hi @srikanth-sankaran , could you take a look here? If you check this PR out and run It looks like the the anonymous type in Only this is on the stack: Shouldn't there be more? Likewise values are on stack when retrieving the element info of the anonymous type: Best regards, |
Contributor
|
Hi @trancexpress I will study this but it will take some time to wrap up the things I am working on. In the meanwhile CCing @jarthana who is our model expert. |
Contributor
Author
|
Thank you! I don't think we are in a rush here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #4707