Fix package name and folder mismatch for some test cases#4361
Open
datho7561 wants to merge 1 commit intoeclipse-jdt:masterfrom
Open
Fix package name and folder mismatch for some test cases#4361datho7561 wants to merge 1 commit intoeclipse-jdt:masterfrom
datho7561 wants to merge 1 commit intoeclipse-jdt:masterfrom
Conversation
See eclipse-jdt#4250 Some test classes have different folder and package names. `javac` uses the package name stated in the class if there's a mismatch, and ECJ uses the folder name. However, these tests aren't testing for that behaviour; the package mismatch seems to have been an oversight of the person coding the tests. As a result, I think it's best to make the package and folder line up properly. Signed-off-by: David Thompson <davthomp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
See #4250
Some test classes have different folder and package names.
javacuses the package name stated in the class if there's a mismatch, and ECJ uses the folder name. However, the tests using these classes aren't testing for that behaviour; the package mismatch seems to have been an oversight of the person coding the tests.As a result, I think it's best to make the package and folder line up properly.
How to test
This involves changes to the existing test case; those tests should still pass
Author checklist