Fix #339 - In the Java 5-6 era, ECJ was patched to be bug-compatible …

[gzsombor]

…with Javac of that time.

Luckily, Javac fixed so the hack is not needed anymore - infact this makes ECJ not following JLS properly

What it does

Described in #339

How to test

Try compiling the code:

public class X {
	
	String z() { return Y.MSG; }

	@WithMsg(Y.MSG)
	static class Y {
		private final static String MSG = "msg";
	}
}
@interface WithMsg {
	String value();
}

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[gzsombor]

It's unclear for me, why the build failed, could anyone help with a clue?

[iloveeclipse]

It's unclear for me, why the build failed, could anyone help with a clue?

Probably because we had 4.25 -> 4.26 version switch in the meantime. I've rebased the branch, please watch for the test results now (since github doesn't send mails on build finish).

[iloveeclipse]

please watch for the test results now (since github doesn't send mails on build finish).

Need to wait till we have solution for #381.

[iloveeclipse]

I've rebased the branch (it will have workaround for #381), please watch for the test results now (since github doesn't send mails on build finish).

[gzsombor]

Thanks for your help, you were right, that fixed the build!

[srikanth-sankaran]

This PR is problematic and has resulted in #1216
This PR makes org.eclipse.jdt.core.tests.compiler.regression.AnnotationTest.test293() a conformance test rather than a negative test but that is wrong - it should stay a negative test.

I will address the problem comprehensively in #4828