Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#264] Extend service builder pub sub parameter #382

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 18, 2024

Notes for Reviewer

This PR extends the available parameter for the pub-sub service builder.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #264

@elBoberido elBoberido self-assigned this Sep 18, 2024
@elBoberido elBoberido force-pushed the iox2-264-extend-service-builder-pub-sub-parameters branch from 851a610 to 0b37e7a Compare September 18, 2024 13:28
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.49%. Comparing base (4b2f409) to head (0b37e7a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   79.49%   79.49%   -0.01%     
==========================================
  Files         193      193              
  Lines       22716    22716              
==========================================
- Hits        18059    18058       -1     
- Misses       4657     4658       +1     

see 4 files with indirect coverage changes

Copy link
Contributor

@orecham orecham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elBoberido elBoberido merged commit 104a197 into eclipse-iceoryx:main Sep 18, 2024
55 checks passed
@elBoberido elBoberido deleted the iox2-264-extend-service-builder-pub-sub-parameters branch September 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants