Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2329 Use iox::concurrent::Atomic #2332

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Aug 21, 2024

Notes for Reviewer

This PR replaces std::atomic with iox::concurrent::Atomic and adds a shell script to check for invalid use of std::atomic

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-2329-use-iox-atomic branch 2 times, most recently from d6634f8 to 6b42ea3 Compare August 21, 2024 03:17
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (8a2a18f) to head (bf4e66a).
Report is 5 commits behind head on main.

Files Patch % Lines
iceoryx_posh/source/runtime/posh_runtime.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2332   +/-   ##
=======================================
  Coverage   78.21%   78.22%           
=======================================
  Files         433      433           
  Lines       16028    16034    +6     
  Branches     2303     2302    -1     
=======================================
+ Hits        12537    12543    +6     
  Misses       2644     2644           
  Partials      847      847           
Flag Coverage Δ
unittests 78.05% <50.00%> (+<0.01%) ⬆️
unittests_timing 15.04% <0.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ncurrent/buffer/include/iox/detail/mpmc_loffli.hpp 100.00% <ø> (ø)
...lude/iox/detail/mpmc_resizeable_lockfree_queue.hpp 100.00% <ø> (ø)
...concurrent/buffer/include/iox/detail/spsc_sofi.hpp 100.00% <ø> (ø)
...ryx_hoofs/concurrent/buffer/source/mpmc_loffli.cpp 87.09% <ø> (-0.41%) ⬇️
.../design/include/iox/detail/polymorphic_handler.inl 87.17% <ø> (ø)
...esign/include/iox/detail/static_lifetime_guard.inl 94.28% <ø> (+0.73%) ⬆️
iceoryx_hoofs/posix/ipc/include/iox/named_pipe.hpp 100.00% <ø> (ø)
...yx_hoofs/posix/sync/include/iox/signal_watcher.hpp 100.00% <ø> (ø)
iceoryx_hoofs/posix/sync/include/iox/thread.hpp 100.00% <ø> (ø)
.../include/iox/detail/log/building_blocks/logger.inl 58.97% <ø> (ø)
... and 17 more

... and 1 file with indirect coverage changes

@elBoberido elBoberido changed the title [Based on #2331] iox-#2329 Use iox::concurrent::Atomic iox-#2329 Use iox::concurrent::Atomic Aug 21, 2024
…esConditionVariable test due to sporadic failures on macOS
@elBoberido elBoberido self-assigned this Aug 21, 2024
@elBoberido elBoberido merged commit 5bca9a4 into eclipse-iceoryx:main Aug 22, 2024
25 checks passed
@elBoberido elBoberido deleted the iox-2329-use-iox-atomic branch August 22, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add std::atomic abstraction
2 participants