-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2329 Use iox::concurrent::Atomic #2332
Merged
elBoberido
merged 4 commits into
eclipse-iceoryx:main
from
elBoberido:iox-2329-use-iox-atomic
Aug 22, 2024
Merged
iox-#2329 Use iox::concurrent::Atomic #2332
elBoberido
merged 4 commits into
eclipse-iceoryx:main
from
elBoberido:iox-2329-use-iox-atomic
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
force-pushed
the
iox-2329-use-iox-atomic
branch
2 times, most recently
from
August 21, 2024 03:17
d6634f8
to
6b42ea3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
=======================================
Coverage 78.21% 78.22%
=======================================
Files 433 433
Lines 16028 16034 +6
Branches 2303 2302 -1
=======================================
+ Hits 12537 12543 +6
Misses 2644 2644
Partials 847 847
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elBoberido
force-pushed
the
iox-2329-use-iox-atomic
branch
from
August 21, 2024 12:15
6b42ea3
to
985087d
Compare
elBoberido
changed the title
[Based on #2331] iox-#2329 Use iox::concurrent::Atomic
iox-#2329 Use iox::concurrent::Atomic
Aug 21, 2024
elBoberido
force-pushed
the
iox-2329-use-iox-atomic
branch
from
August 21, 2024 12:50
985087d
to
773d493
Compare
elBoberido
force-pushed
the
iox-2329-use-iox-atomic
branch
from
August 21, 2024 13:06
773d493
to
8513ab3
Compare
…esConditionVariable test due to sporadic failures on macOS
elfenpiff
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
This PR replaces
std::atomic
withiox::concurrent::Atomic
and adds a shell script to check for invalid use ofstd::atomic
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References