Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix: paramater --> parameter #2326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GerHobbelt
Copy link

Notes for Reviewer

As it says on the tin. Just a very minor English language tidbit.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of [CONTRIBUTING.md][contributing]
  2. Add sensible notes for the reviewer

@elBoberido
Copy link
Member

@GerHobbelt since we are an Eclipse project, you need to sign the ECA. Without that, we can not merge the PR.

Also, since iceoryx is used in a safety critical environment we have to follow rules for traceability. One of the rules is that the commit message must have the issue number of the related issue at the front. Usually, we have to create an issue first before we create commits but for such small changes you can use #2305. Can you please change the commit message to

iox-#3205 Typo fix: paramater -> parameter

And also add

Relates to #2305

to the bottom of the PR description

@elBoberido
Copy link
Member

@GerHobbelt are you planing to continue on this? If not, I would fix the typo with one of my next PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants