-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1036 Builder pattern for message queue #2014
Merged
elBoberido
merged 4 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1036-builder-pattern-for-message-queue
Sep 4, 2023
Merged
iox-#1036 Builder pattern for message queue #2014
elBoberido
merged 4 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1036-builder-pattern-for-message-queue
Sep 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
added
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
labels
Sep 1, 2023
elBoberido
requested review from
mossmaurice,
dkroenke,
elfenpiff,
MatthiasKillat and
FerdinandSpitzschnueffler
September 1, 2023 16:17
elfenpiff
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor findings. From my point of view it can be merged if these are addressed
iceoryx_dust/include/iceoryx_dust/posix_wrapper/message_queue.hpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
- Coverage 74.31% 74.18% -0.13%
==========================================
Files 414 415 +1
Lines 16085 16102 +17
Branches 2248 2254 +6
==========================================
- Hits 11953 11945 -8
- Misses 3416 3435 +19
- Partials 716 722 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elBoberido
force-pushed
the
iox-1036-builder-pattern-for-message-queue
branch
from
September 1, 2023 18:29
b2c853d
to
3b7f0ce
Compare
21 tasks
elBoberido
force-pushed
the
iox-1036-builder-pattern-for-message-queue
branch
from
September 1, 2023 19:29
3b7f0ce
to
3b67f47
Compare
21 tasks
FerdinandSpitzschnueffler
approved these changes
Sep 4, 2023
elfenpiff
approved these changes
Sep 4, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR continues with the porting of the creation pattern to the builder pattern by taking care of the
MessageQueue
. The remaining classes will be done in a follow up.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References