Iceperf example updated - ein bisschen less advertisement

[anderay]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Extend 'iceperf' with 'WaitSet' #2003

[elfenpiff]

@anderay Thanks for the contribution!

Could you please follow the contribution guidelines from here: https://github.com/eclipse-iceoryx/iceoryx/blob/master/CONTRIBUTING.md

Things you still have to do:

1. Sign the Eclipse Committer Agreement
2. Create an issue what you implemented here so that other reviewers see the intention of the changes.
3. The pull request name, every comment etc. should be in the english language
4. The PR should have the prefix iox-??? where ??? is the issue number (the issue you created in 2.)
5. Every commit requires the prefix iox-#??? (do not forget the # here)

Please remove all the commented out code.

As soon this is realized I am happy to review the PR.

[elBoberido]

@anderay please also run clang-format on your code.

I skimmed over the PR and it is great to soon have a performance test with the WaitSet. I had it since ages on my to-do list so I'm happy to see this PR.

[codecov]

Codecov Report

Merging #1860 (46358c6) into master (15c82fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1860   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files         414      414           
  Lines       16086    16086           
  Branches     2249     2249           
=======================================
  Hits        11955    11955           
  Misses       3416     3416           
  Partials      715      715           

Flag	Coverage Δ
unittests	74.10% <ø> (ø)
unittests_timing	14.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

[elBoberido]

Nice. Just a few small remarks. Looks good overall.

[elBoberido]

@anderay do you plan to continue working on this PR?

[andrzejpolanskiaptiv]

@anderay do you plan to continue working on this PR?

What else is needed?

[elBoberido]

@andrzejpolanskiaptiv the biggest issue is the Eclipse ECA. Since we are an Eclipse project, all contributors must sign the ECA. There is also a CI check for this which prevents merging.

If you want, you can also implement the proposal from #1860 (comment) but that is not required. Your answer was a bit ambiguous

[andrzejpolanskiaptiv]

"You successfully submitted an Eclipse Contributor Agreement"
But seems not be visible here...

[elBoberido]

@andrzejpolanskiaptiv It might take some time until everything is synchronized and the check passes. Just in case, did you sign with the same e-mail address as you used for your commits?

[andrzejpolanskiaptiv]

@andrzejpolanskiaptiv It might take some time until everything is synchronized and the check passes. Just in case, did you sign with the same e-mail address as you used for your commits?

I did it long time ago. Now I see that in commits my company email is stated whilst in ECA private was used. Perhaps that was the problem. I have changed address in Eclipse account, will see...

[elBoberido]

Looks good. Just a few minor things.

• please tick the checkboxes from the PR author checklist
• please add iox-#2003 to your commit messages, e.g. iox-#2003 Iceperf example - ein bisschen less advertisement (I created Extend 'iceperf' with 'WaitSet' #2003 for this purpose)
• please add an entry to iceoryx-unreleased.me like - Extend 'iceperf' with 'WaitSet' [#2003](https://github.com/eclipse-iceoryx/iceoryx/issues/2003) in the Features section
• please rebase to latest master, it seems the CI is not triggered for whatever reasons

[anderay]

here you are

[elBoberido]

Okay, we are really really close. Only the bazel build needs some adjustments and then I can approve the PR :)

Could you please add iceoryx_wait.hpp/cpp to BAZEL.build. Right after iceoryx_c.hpp/cpp

[mossmaurice]

LGTM, thanks for the PR! 🙏