hawkbit-ddi-resource: do not log range requests

[zyga]

HawkBit creates ActionStatus entries for each GET request associated with an
artefact of an assigned software module. Amongst others, this severely breaks
RAUC block-based adaptive updates [1], which issue a flurry of range requests
for small chunks, so that the whole image does not have to be streamed in case
of incremental system changes.

[1] https://rauc.readthedocs.io/en/latest/advanced.html#block-based-adaptive-update-block-hash-index

Fixes: #1249

[hawkbit-bot]

Can one of the admins verify this patch?

[zyga]

NOTE: this is failing in tests that observe download progress.

[MartB]

Nice job!

I dont think its important to have these range requests logged anyway, its a thing between client and server and it should always be followed up with another action status, no matter what happens. For client integration debugging purposes its much easier to just add a logger on the fly. As it is right now, this provides 0 benefits for normal users.

Edit: I hit submit too early.

I do think that some sort of "Download Progress" is needed, but if the client is streaming it would be much better if the client was in charge of emitting these actions, as it might not be a consecutive download anyway and downloading 10% of the update package might even be 90% of the download progress on the client side.

[zyga]

I can look at removing the database entries while keeping the progress callback intact. If you have any suggestions I'm happy to learn.

[zyga]

@MartB I've pushed a small update. I think making the current download progress event work is futile, with my limited knowledge of spring, it seems that the underlying class requires an non-null object and in this case it was always the ActionStatus instance that was tied to a database entry.