-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create delegate on InflaterInputStream and DeflaterOutputStream #5744
base: 2.x
Are you sure you want to change the base?
Conversation
Please see our wiki about missing ECA. |
The behaviour is the same in JDK 8, the Deflater and Inflater are not called there, either. |
* @see java.util.zip.Deflater | ||
* @see java.util.zip.DeflaterOutputStream | ||
*/ | ||
public final class ClosingDeflaterOutputStream extends OutputStream { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to make those classes package-private private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't make this class package-private and keep it in the internal package.
Do you want me to move those classes in the package 'org.glassfish.jersey.message' or to create inner classes ?
@jansupol in JDK 8, the finalizer of Deflater & Inflater contains a call the end() method that will release correctly the Deflater/Inflater. |
…ll end on Inflater and Deflater Signed-off-by: Tanguy Lambert <[email protected]> Add missing import Add missing Copyright comments Signed-off-by: Tanguy LAMBERT <[email protected]>
Those delegate are here to be sure the Inflater and Deflater resources are correctly released