Update java version from <1.8 to 17 #124#125
Closed
jukzi wants to merge 1 commit intoeclipse-ecf:masterfrom
Closed
Update java version from <1.8 to 17 #124#125jukzi wants to merge 1 commit intoeclipse-ecf:masterfrom
jukzi wants to merge 1 commit intoeclipse-ecf:masterfrom
Conversation
fixes eclipse-ecf#124 regular expression search and replace: in org.eclipse.jdt.core.prefs: (org.eclipse.jdt.core.compiler.codegen.targetPlatform|org.eclipse.jdt.core.compiler.compliance|org.eclipse.jdt.core.compiler.source)=.* -> $1=17 in .classpath: org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/([^"]*) -> org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17
|
Can one of the admins verify this patch? |
merks
reviewed
Aug 12, 2024
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
FYI, it's likely these values aren't necessarily consistent with the MANIFEST.MF especially given none of the MANIFEST.MFs are changed by this PR.
Contributor
|
I haven't gone through all of these changes yet, but it's possible that many of the project level changes (to classpath, .prefs, etc) will require changes to MANIFEST.MF (for consistency...as Ed indicates) and so also will require increment of the service segment of the version number rather than just changing the qualifier. I can't commit to doing that work in this release cycle, so I'm not going to merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #124
regular expression search and replace:
in org.eclipse.jdt.core.prefs:
(org.eclipse.jdt.core.compiler.codegen.targetPlatform|org.eclipse.jdt.core.compiler.compliance|org.eclipse.jdt.core.compiler.source)=.*
-> $1=17
in .classpath:
org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/([^"]*)
-> org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17