Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Service] Added support for .local mDNS in eCAL Services #1586

Merged
merged 12 commits into from
May 7, 2024

Conversation

FlorianReimold
Copy link
Member

Description

Added support for resolving Hostname.local (-> mDNS) hosts

  • eCAL Services Lib now supports a list of endpoints to connect to. They will be tried one after another
  • eCAL Core uses a list of {Hostname, Hostname.local} to make the service client connect to the mDNS TLD host, if the Hostname alone was not sufficient

Related issues

@FlorianReimold FlorianReimold added the cherry-pick-to-NONE Don't cherry-pick these changes label May 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

std::cout << "Usage: " << arg0 << " [--port <Port>] [--protocol-version <Version>]" << std::endl;
}

int main(int argc, char** argv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape]

int main(int argc, char** argv)
    ^

@FlorianReimold FlorianReimold merged commit 1fd8cde into master May 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants