Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Helm chart by startupProbe #2063

Merged

Conversation

thjaeckle
Copy link
Member

  • and more configuration options, e.g. several topologySpreadConstraints
  • also configure "ephemeral-storage" requests and limits

@thjaeckle thjaeckle added this to the 3.6.3 milestone Nov 15, 2024
@thjaeckle thjaeckle self-assigned this Nov 15, 2024
@thjaeckle thjaeckle force-pushed the enhance-helm-chart-startup branch from d2b8e31 to 16f8c06 Compare November 15, 2024 09:56
* and more configuration options, e.g. several topologySpreadConstraints
* also configure "ephemeral-storage" requests and limits
@thjaeckle thjaeckle force-pushed the enhance-helm-chart-startup branch from 16f8c06 to 2a87bd2 Compare November 15, 2024 10:03
@thjaeckle
Copy link
Member Author

@kalinkostashki @alstanchev whoever wants to, a quick look at this would be nice.

By using startupProbe, the initialDelaySeconds of the readinessProbe can be removed - as the readinessProbe is only started after the startup probe succeeded.

We also had the requirement to configure more than a single topologySpreadConstraint, so I changed that to be an array.

@alstanchev
Copy link
Contributor

LGTM 👍

@thjaeckle thjaeckle merged commit 541de7a into eclipse-ditto:master Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants