Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard add scroll-to-today #6145

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

pmattmann
Copy link
Member

related to #5608

Not a auto-scroll
But a link to scroll to 'today'

To test:

  • create a camp with a start-date in the past and an end-date in the future.
  • goto dashboard
  • see icon on the top right

@pmattmann pmattmann requested a review from a team October 13, 2024 18:56
@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Oct 13, 2024
Copy link

github-actions bot commented Oct 13, 2024

Feature branch deployment ready!

Name Link
😎 Deployment https://pr6145.ecamp3.ch/
🔑 Login [email protected] / test
🕒 Last deployed at Sun Oct 13 2024 22:10:59 GMT+0200
🔨 Latest commit b1024c2dfb6be698e5670aad308bdecdc5800737
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/11317327693/job/31470701162
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool idea!

I think clock-in-custom could be more clear. Also I'm not sure of the placement of this button. Maybe it could be a floating action button that is only visible if the tbody isn't visible (IntersectionObserver).

@@ -58,7 +64,7 @@
:key="dayUri"
:aria-labelledby="dayUri + 'th'"
>
<tr class="day-header__row">
<tr :ref="days[dayUri].id" class="day-header__row">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be set on the tbody and preferably as an id. Which we could reflect in the url.

Then the tbody should have a scroll-margin-top with the same value as the top of the .day-header: So the navbar does not cover the content:

Bildschirmfoto 2024-10-14 um 08 38 49

If solved as an id, someone could then share this link and it will automatically go to the same day.

Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to comment of @manuelmeister.
As this button/icon is really only visible during the actual camp, I would be ok with an action button with actual text (for example: "go to today" or shorter "today")

Also for me the scrolling action is always a bit too far (day header is not shown anymore), both on mobile and on desktop. I think this could be fine-tuned either with the block option or with scroll-margin-top css.

Code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants