Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin/MaterialList add icon #5537

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

pmattmann
Copy link
Member

Admin / Materiallist
Add icon

if it is a User-MaterialList, add UserAvatar
else add mdi-format-list-bulleted-square

image

@pmattmann pmattmann requested a review from a team July 13, 2024 17:49
@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

Feature branch deployment ready!

Name Link
😎 Deployment https://pr5537.ecamp3.ch/
🔑 Login [email protected] / test
🕒 Last deployed at Tue Aug 27 2024 20:56:43 GMT+0200
🔨 Latest commit 5d04cb42979c4c685d78fd924c3565e8d7003db5
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/10584079338/job/29327776713
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe add the icon on all places where we display the material list name

@manuelmeister manuelmeister added the Cool Ideas Proof of concepts label Aug 6, 2024
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would want to discuss this in the core meeting before we merge this.

@pmattmann pmattmann added the Meeting Discuss Am nächsten Core-Meeting besprechen label Aug 6, 2024
@BacLuc
Copy link
Contributor

BacLuc commented Aug 8, 2024

I would want to discuss this in the core meeting before we merge this.

Did you discuss this yet?

@carlobeltrame
Copy link
Member

The discussion will also be about whether we will actively use the relation from material list to user from now on, and what implications this will have on collaborators entering and leaving and re-entering the camp, claiming invitations sent to other emails etc.
Some years ago we already discussed this to great lengths, and came to the conclusion to only use this relation minimally, due to the complexity. In the meeting last week, we postponed taking up this discussion again to a later meeting or hackathon, because it is expected to take some time.

@pmattmann pmattmann added Next Hackathon and removed Meeting Discuss Am nächsten Core-Meeting besprechen labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cool Ideas Proof of concepts deploy! Creates a feature branch deployment for this PR Next Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants