hotfix: braxis wave not spawning crashes match details

ebshimizu · Feb 25, 2018 · 2a4b5b6 · 2a4b5b6
1 parent 3ee7b07
commit 2a4b5b6
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 37 deletions.
diff --git a/js/match-detail.js b/js/match-detail.js
@@ -1066,42 +1066,44 @@ function getBraxisEvents(items) {
     let item0 = {};
     let item1 = {};
 
-    item0.start = wave.startTime;
-    item1.start = wave.startTime;
-    item0.end = wave.endTime[0];
-    item1.end = wave.endTime[1];
-
-    item0.className = 'blue';
-    item1.className = 'red';
-
-    let t0 = (wave.startScore[0] * 100).toFixed(2) + '% Zerg Wave';
-    let t1 = (wave.startScore[1] * 100).toFixed(2) + '% Zerg Wave';
-
-    let pop0 = "<h3 class='ui header'>";
-    pop0 += "<div class='content'>" + t0 + "<div class='sub header'>Spawned at: " + formatSeconds(item0.start) + ", Duration: " + formatSeconds(item0.end - item0.start);
-    pop0 += "</div></div></h3>";
-
-    let pop1 = "<h3 class='ui header'>";
-    pop1 += "<div class='content'>" + t1 + "<div class='sub header'>Spawned at: " + formatSeconds(item1.start) + ", Duration: " + formatSeconds(item1.end - item1.start);
-    pop1 += "</div></div></h3>";
-
-    item0.content = '<div class="timeline-popup" data-variation="wide" data-html="' + pop0 + '">' + t0 + '</div>';
-    item1.content = '<div class="timeline-popup" data-variation="wide" data-html="' + pop1 + '">' + t1 + '</div>';
-
-    item0.group = 54
-    item1.group = 5;
-
-    items.push(item0);
-    items.push(item1);
-
-    // spawns
-    sitem = {};
-    sitem.start = wave.initTime;
-    sitem.content = "Beacons Active";
-    sitem.type = 'background';
-    sitem.group = 5;
-    sitem.end = wave.startTime;
-    items.push(sitem);
+    if ('startTime' in wave) {
+      item0.start = wave.startTime;
+      item1.start = wave.startTime;
+      item0.end = wave.endTime[0];
+      item1.end = wave.endTime[1];
+
+      item0.className = 'blue';
+      item1.className = 'red';
+
+      let t0 = (wave.startScore[0] * 100).toFixed(2) + '% Zerg Wave';
+      let t1 = (wave.startScore[1] * 100).toFixed(2) + '% Zerg Wave';
+
+      let pop0 = "<h3 class='ui header'>";
+      pop0 += "<div class='content'>" + t0 + "<div class='sub header'>Spawned at: " + formatSeconds(item0.start) + ", Duration: " + formatSeconds(item0.end - item0.start);
+      pop0 += "</div></div></h3>";
+
+      let pop1 = "<h3 class='ui header'>";
+      pop1 += "<div class='content'>" + t1 + "<div class='sub header'>Spawned at: " + formatSeconds(item1.start) + ", Duration: " + formatSeconds(item1.end - item1.start);
+      pop1 += "</div></div></h3>";
+
+      item0.content = '<div class="timeline-popup" data-variation="wide" data-html="' + pop0 + '">' + t0 + '</div>';
+      item1.content = '<div class="timeline-popup" data-variation="wide" data-html="' + pop1 + '">' + t1 + '</div>';
+
+      item0.group = 54
+      item1.group = 5;
+
+      items.push(item0);
+      items.push(item1);
+
+      // spawns
+      sitem = {};
+      sitem.start = wave.initTime;
+      sitem.content = "Beacons Active";
+      sitem.type = 'background';
+      sitem.group = 5;
+      sitem.end = wave.startTime;
+      items.push(sitem);
+    }
   }
 }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "stats-of-the-storm",
-  "version": "0.3.0-dev",
+  "version": "0.2.2",
   "main": "main.js",
   "description": "A Heroes of the Storm stat tracking application.",
   "bugs": "[email protected]",

diff --git a/templates/about-page.html b/templates/about-page.html
@@ -16,6 +16,8 @@ <h2 class="ui inverted header">Stats of the Storm - Version <span class="app-ver
           gets talent and hero information and images from <a href="https://github.com/heroespatchnotes/heroes-talents">heroes-talents</a>.
         </p>
         <div class="ui inverted horizontal divider">Change Log</div>
+        <h3 class="ui inverted dividing header">Version 0.2.2</h3>
+        <p>Match Details: Corrected an issue for Braxis Holdout, where beacons would spawn but the game would end before a wave would spawn, causing a crash in the timeline view</p>
         <h3 class="ui inverted dividing header">Version 0.2.1</h3>
         <p>Draft Stats: hotfix for pre-2.0 (client version 2.25.0) replays missing draft pick and ban data.</p>
         <p>Correctly applied player game threshold to Player Details with/against player tables.</p>