Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add p0 to OR conversion #659

Merged
merged 10 commits into from
Dec 8, 2024
Merged

add p0 to OR conversion #659

merged 10 commits into from
Dec 8, 2024

Conversation

mattansb
Copy link
Member

@mattansb mattansb commented Dec 5, 2024

No description provided.

@mattansb

This comment was marked as resolved.

@mattansb

This comment was marked as resolved.

@mattansb
Copy link
Member Author

mattansb commented Dec 7, 2024

So effectively, the chen2010 rule is dropped - the default now is to use and OR to d transformation (possibly with p0 provided) and interpreted according to Cohen's 0.2, 0.5, & 0.8 thresholds.

@rempsyc this might break some tests in report?

@mattansb mattansb merged commit 21fc13c into main Dec 8, 2024
21 of 22 checks passed
@mattansb mattansb deleted the exact-p0 branch December 8, 2024 07:49
@rempsyc
Copy link
Member

rempsyc commented Dec 12, 2024

@rempsyc this might break some tests in report?

Solved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants