Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve portability of reproducible tarballs by replacing external tar command with tarfile module #4660

Open
wants to merge 10 commits into
base: 5.0.x
Choose a base branch
from

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Sep 27, 2024

fixes #4657

  • use more portable --date argument for touch
  • catch failed commands inside the pipeline
  • move generation of command to make reproducible archives intro its own method
  • replace harcoded pattern in tests of reproducible archives command for call to filetools.reproducible_archive_cmd
  • make new implementation of reproducible_archive_cmd using the tarfile module
  • added new filetools.make_archive() method and related unit test
  • change handling of filename argument in filetools.get_source_tarball_from_git() to expect filenames without extension
    • archive extension is appended as needed by make_archive()
    • known archive extensions are automatically removed from filename if it contains one
  • add required argument to filetools.find_extensions()

@boegel boegel added this to the 5.0 milestone Oct 2, 2024
@boegel boegel changed the title use more portable --date argument for touch command used in reproducible tarballs use more portable --date argument for touch command used in reproducible tarballs Oct 2, 2024
test/framework/filetools.py Outdated Show resolved Hide resolved
@lexming lexming changed the title use more portable --date argument for touch command used in reproducible tarballs improve portability of reproducible tarballs by replacing external tar command with tarfile module Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Blockers
Development

Successfully merging this pull request may close these issues.

2 participants