Replace parallel easyconfig parameter by maxparallel
#4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
parallel EC parameter by maxparallelparallel easyconfig parameter by maxparallel
Flamefire
force-pushed
the
deprecate_parallel-5.0
branch
from
d2ef1e7
to
91ebd42
Compare
Flamefire
force-pushed
the
deprecate_parallel-5.0
branch
from
91ebd42
to
0c58470
Compare
Flamefire
force-pushed
the
deprecate_parallel-5.0
branch
from
0c58470
to
af62d8e
Compare
Flamefire
force-pushed
the
deprecate_parallel-5.0
branch
from
af62d8e
to
a793f08
Compare
ec['parallel'] currently doubles as an EC option and as the storage for the calculated parallelism set by the EasyBlock. This makes it hard to reason about especially as maxparallel has pretty much the same effect. Also changes to ec['parallel'] done by e.g. easyblocks (or the set_parallel method) are not reflected by the template `%(parallel)s` Solution: Introduce a property which on write updates the template and some magic to mirror the effect of the now deprecated ec['parallel']
Migrate from `self.cfg['parallel']` to `self.cfg.parallel`
We need to fix our own easyblocks first but that requires this change. So allow until 5.1 or remove after updating the easyblocks.
The EC parameter is deprecated so the tests fail.
Flamefire
force-pushed
the
deprecate_parallel-5.0
branch
from
a793f08
to
6dbe018
Compare
|
@Flamefire Not supporting the So I think we should proceed with #4580 instead, and only actually remove support for using the So this PR should probably be closed, I'll look into reviewing #4580 ASAP... |
|
Agreed, especially as this is basically #4580 with an extra commit which we can apply at any later point. The EC PR is still useful to promote the use of the new name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3842 for 5.0 to fully remove the
parallelEC parameterRequires:
parallelbymaxparalleleasybuild-easyconfigs#19375paralleleasyconfig parameter and fix updating the template value #4580