Skip to content

Conversation

@Besroy
Copy link
Contributor

@Besroy Besroy commented Feb 3, 2026

  1. concurrency issue between remove logdev and device truncate
  2. log index→entry misalignment (issue: log index→entry misalignment #857)
  3. fix metric compute logic

Related sisl pr: eBay/sisl#294

@Besroy Besroy marked this pull request as draft February 3, 2026 09:42
@Besroy Besroy force-pushed the fix_concurrency branch 9 times, most recently from 8e516e8 to b5fbf1c Compare February 9, 2026 10:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.33%. Comparing base (fe47d46) to head (f514f61).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/logstore/log_store.cpp 0.00% 0 Missing and 1 partial ⚠️
src/lib/logstore/log_store_service.cpp 0.00% 0 Missing and 1 partial ⚠️
.../lib/replication/log_store/home_raft_log_store.cpp 50.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   48.26%   48.33%   +0.06%     
==========================================
  Files         110      110              
  Lines       12872    12872              
  Branches     6176     6176              
==========================================
+ Hits         6213     6222       +9     
+ Misses       2567     2556      -11     
- Partials     4092     4094       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

1. concurrency issue between remove logdev and device truncate
2. log index->entry misalignment (issue: eBay#857)
3. fix metric compute logic
@Besroy Besroy marked this pull request as ready for review February 11, 2026 00:02
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you in the commit log providing more info for the first 2 fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants