Conversation
Collaborator
|
can you give more context about this change? does the sequence in switch matter? |
Current toBlobError logic will trans ReplServiceError BAD_REQUEST...DATA_DUPLICATED to BlobError NO_SPACE_LEFT, which is expected to be trans as REPLICATION_ERROR
Contributor
Author
Sure, I updated the context in the commit message. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 63.15% 54.44% -8.72%
==========================================
Files 32 35 +3
Lines 1900 4952 +3052
Branches 204 627 +423
==========================================
+ Hits 1200 2696 +1496
- Misses 600 1971 +1371
- Partials 100 285 +185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current toBlobError logic will trans ReplServiceError BAD_REQUEST...DATA_DUPLICATED to BlobError NO_SPACE_LEFT, which is expected to be trans as REPLICATION_ERROR