Skip to content

fix error code trans seq#390

Merged
Besroy merged 1 commit intoeBay:mainfrom
Besroy:fix_err_code
Feb 9, 2026
Merged

fix error code trans seq#390
Besroy merged 1 commit intoeBay:mainfrom
Besroy:fix_err_code

Conversation

@Besroy
Copy link
Contributor

@Besroy Besroy commented Feb 9, 2026

Current toBlobError logic will trans ReplServiceError BAD_REQUEST...DATA_DUPLICATED to BlobError NO_SPACE_LEFT, which is expected to be trans as REPLICATION_ERROR

@JacksonYao287
Copy link
Collaborator

can you give more context about this change? does the sequence in switch matter?

Current toBlobError logic will trans ReplServiceError BAD_REQUEST...DATA_DUPLICATED to BlobError NO_SPACE_LEFT,
which is expected to be trans as REPLICATION_ERROR
@Besroy
Copy link
Contributor Author

Besroy commented Feb 9, 2026

can you give more context about this change? does the sequence in switch matter?

Sure, I updated the context in the commit message.

Copy link
Collaborator

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yuwmao yuwmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.44%. Comparing base (1746bcc) to head (b6b6a54).
⚠️ Report is 148 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_blob_manager.cpp 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   63.15%   54.44%   -8.72%     
==========================================
  Files          32       35       +3     
  Lines        1900     4952    +3052     
  Branches      204      627     +423     
==========================================
+ Hits         1200     2696    +1496     
- Misses        600     1971    +1371     
- Partials      100      285     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Besroy Besroy merged commit a64afa0 into eBay:main Feb 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants