Merged
Conversation
JacksonYao287
force-pushed
the
add-blk-metrics-for-gc
branch
2 times, most recently
from
d6e600a to
a182180
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 63.15% 55.46% -7.70%
==========================================
Files 32 35 +3
Lines 1900 4875 +2975
Branches 204 613 +409
==========================================
+ Hits 1200 2704 +1504
- Misses 600 1886 +1286
- Partials 100 285 +185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JacksonYao287
force-pushed
the
add-blk-metrics-for-gc
branch
from
a182180 to
b1325fb
Compare
xiaoxichen
reviewed
Jan 21, 2026
| REGISTER_GAUGE(failed_egc_task_count, "Number of failed emergent gc tasks"); | ||
| REGISTER_GAUGE(total_reclaimed_space_by_gc, "Total reclaimed space by gc task"); | ||
| REGISTER_GAUGE(total_reclaimed_space_by_egc, "Total reclaimed space by emergent gc task"); | ||
| REGISTER_GAUGE(gc_read_blk_count, "Total read blk count by gc in this pdev"); |
Collaborator
There was a problem hiding this comment.
use REGISTER_COUNTER, then you can use COUNTER_INC(gc_read_blk_count, new_pba.blk_count()
Collaborator
Author
There was a problem hiding this comment.
thanks , done
Collaborator
There was a problem hiding this comment.
Some of other metrics like failed_egc_task_count can be moved to counter as well, but it can be done seperately.
xiaoxichen
previously approved these changes
Jan 21, 2026
| REGISTER_GAUGE(total_reclaimed_space_by_gc, "Total reclaimed space by gc task"); | ||
| REGISTER_GAUGE(total_reclaimed_space_by_egc, "Total reclaimed space by emergent gc task"); | ||
| REGISTER_COUNTER(gc_read_blk_count, "Total read blk count by gc in this pdev"); | ||
| REGISTER_COUNTER(gc_write_blk_count, "Total writted blk count by gc in this pdev"); |
Collaborator
Author
There was a problem hiding this comment.
done , thanks
JacksonYao287
force-pushed
the
add-blk-metrics-for-gc
branch
from
4241bd5 to
43aae12
Compare
xiaoxichen
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add two metrics for gc:
gc_read_blk_count : total read blk count in this pdev issued by gc
gc_write_blk_count : total write blk count in this pdev issued by gc
these two metrics are not persisted, which means they will start from 0 if sm restarts