Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shunt controller & more descriptive validation in PF2pp validate #2380

Merged
merged 24 commits into from
Aug 29, 2024

Conversation

pawellytaev
Copy link
Contributor

Warning, this PR has station controller merged into it. Merge this only after PR #2228 is merged

This PR contains:

  • Discrete shunt controller for local voltage regulation with shunts
  • more descriptive PF2pp diffs --> now as DataFrame with columns diff, pandapower results & PowerFactory results. Currently not implemented for all elements, this will be done in a separate PR

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 64.89362% with 66 lines in your changes missing coverage. Please review.

Project coverage is 76.00%. Comparing base (be0f2cf) to head (6e4d088).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 0.00% 31 Missing ⚠️
pandapower/converter/powerfactory/validate.py 75.86% 21 Missing ⚠️
pandapower/control/controller/shunt_control.py 79.10% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2380      +/-   ##
===========================================
- Coverage    76.04%   76.00%   -0.04%     
===========================================
  Files          281      282       +1     
  Lines        32798    32943     +145     
===========================================
+ Hits         24940    25038      +98     
- Misses        7858     7905      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vogt31337 vogt31337 merged commit d2700a7 into e2nIEE:develop Aug 29, 2024
14 of 25 checks passed
@pawellytaev pawellytaev deleted the shunt_controller branch August 29, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants