Skip to content

Commit

Permalink
chore: support node 16, single e2e
Browse files Browse the repository at this point in the history
- add support for node 16
- update readme for running single e2e test
  • Loading branch information
dylants committed Aug 13, 2023
1 parent 83d525d commit e3ddca8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [18.x]
node-version: [16.x, 18.x]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ To execute the end to end tests run:
$ yarn test:e2e
```

To execute a specific end to end test run:

```
$ yarn test:e2e:single test/e2e/<test file>
```

#### Adding Sites ####

This project was built to easily drop in support for new sites. The `site-manager` iterates over all files contained within the `sites` directory, and adds it to the list of available sites. When a request is issued to price-finder to look up a price, it asks each site if the `uri` is supported by the site, and if so, uses that site to find the price.
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Finds the prices of retail items online",
"version": "6.0.0-alpha.2",
"engines": {
"node": "^18"
"node": ">=16"
},
"author": {
"name": "Dylan Smith"
Expand Down Expand Up @@ -43,6 +43,7 @@
"rome:format": "yarn rome format src/ test/",
"test": "jest test/unit",
"test:e2e": "jest test/e2e",
"test:e2e:single": "jest $1",
"test:watch": "yarn test --watch"
},
"dependencies": {
Expand Down

0 comments on commit e3ddca8

Please sign in to comment.