<type-error>: fix test and remove condition-to-string method #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `condition-to-string(<type-error>)` because `condition-to-string(<simple-condition>)` already does the same job. * Add `make-condition(<type-error>)` to supply the required init args for the test. * Make both value: and type: be required init keywords. Potentially controversial since they're not specified as required in the DRM, but the error is meaningless without these slots set and this would have uncovered the test suite bug right away.
cgay
changed the title
housel
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<type-error>: fix test and remove condition-to-string methodRemove
condition-to-string(<type-error>)becausecondition-to-string(<simple-condition>)already does the same job.Add
make-condition(<type-error>)to supply the required init args for thetest.
Make both value: and type: be required init keywords. Potentially
controversial since they're not specified as required in the DRM, but the
error is meaningless without these slots set and this would have uncovered the
test suite bug right away.