Implement DEP 12, string literals supporting Rectangle Rule #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housel
approved these changes
Oct 1, 2023
| // When this is called `string` is known to contain at least one literal newline | ||
| // character, the EOL sequence has already been canonicalized to just '\n', escape | ||
| // sequences have been processed, and the start/end delimiters have been removed. | ||
| define function trim-multi-line-prefix |
There was a problem hiding this comment.
There are probably efficiency improvements that could be made to this function, but I guess it won't be a bottleneck in compiling most programs so it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://opendylan.org/proposals/dep-0012-string-literals.html#the-rectangle-rule for details.
This implements everything except for the ability to use three or more double quotes to start/end the multi-line string. Only exactly
"""may be used at this point.