Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom tooltip to Select #1992

Merged
merged 13 commits into from
Jul 12, 2024
Merged

Added custom tooltip to Select #1992

merged 13 commits into from
Jul 12, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented May 10, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
After adding the new Tooltip component, it is required to use it instead of title in the Select component.

Related to #1968, #2036

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented May 10, 2024

Closed until Tooltip component lifecycle status is New.

@Mil4n0r Mil4n0r closed this May 10, 2024
@Mil4n0r Mil4n0r reopened this Jul 9, 2024
@Mil4n0r Mil4n0r marked this pull request as draft July 9, 2024 12:57
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Jul 10, 2024

I'm having a small problem with the Select icon not being centered.

@Mil4n0r Mil4n0r marked this pull request as ready for review July 11, 2024 11:05
@GomezIvann GomezIvann merged commit 579b121 into master Jul 12, 2024
4 checks passed
@GomezIvann GomezIvann deleted the Mil4n0r/tooltip-select branch July 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants