fix-destroy-emoji

dwango · Apr 16, 2018 · 3fad6e1 · 3fad6e1
1 parent d4ec182
commit 3fad6e1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/app/controllers/api/v1/custom_emojis_controller.rb b/app/controllers/api/v1/custom_emojis_controller.rb
@@ -31,6 +31,6 @@ def resource_params
   end
 
   def set_custom_emoji
-    @custom_emoji = CustomEmoji.find(params[:id])
+    @custom_emoji = CustomEmoji.local.find_by(shortcode: params[:id])
   end
 end
diff --git a/spec/controllers/api/v1/custom_emojis_controller_spec.rb b/spec/controllers/api/v1/custom_emojis_controller_spec.rb
@@ -15,4 +15,16 @@
       expect(response).to have_http_status(:success)
     end
   end
+
+  describe 'DELETE #destroy' do
+    let(:user) { Fabricate(:user, admin: true) }
+    before { sign_in user }
+    let!(:custom_emoji) { Fabricate(:custom_emoji) }
+    subject { delete :destroy, params: { id: custom_emoji.shortcode }  }
+    it { expect { subject }.to change { CustomEmoji.count }.by(-1) }
+    it do
+      subject
+      expect(response).to have_http_status(:success)
+    end
+  end
 end