Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 168/auto import to erlang #169

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Feature/issue 168/auto import to erlang #169

merged 2 commits into from
Feb 1, 2019
+26 −8

Conversation

yoshihiro503
Copy link
Contributor

resolved #168

amutake
amutake approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@amutake amutake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question

lib/bif.ml
@@ -36,4 +36,6 @@ let type_sigs = [
Type.(of_elem (TyFun ([Type.bool; Type.bool], Type.bool))));
({module_name="erlang"; function_name="not"; arity=1},
Type.(of_elem (TyFun ([Type.bool], Type.bool))));
({module_name="erlang"; function_name="abs"; arity=1},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abs is not in PLT, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thank you for the links!

LGTM.

lib/context.ml

let init () =
let create ~import_modules =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yoshihiro503 yoshihiro503 merged commit 3bce88e into master Feb 1, 2019
@yoshihiro503 yoshihiro503 deleted the feature/issue-168/auto_import_to_erlang branch February 1, 2019 08:19
@yoshihiro503 yoshihiro503 added this to the moyo_monad milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amutake amutake amutake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
moyo_monad
Development

Successfully merging this pull request may close these issues.

Support auto-import BIF
2 participants
@yoshihiro503 @amutake