Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stderr for outputing warnings instead of stdout #26

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

ostrolucky
Copy link
Contributor

@ostrolucky ostrolucky commented Sep 17, 2024

This fixes phpstorm integration, which cannot currrently correctly detect behat version because of output that's mixed with the output from this extension.

image

I even created jetbrains issue but it was difficult to properly formulate the issue at the time https://youtrack.jetbrains.com/issue/WI-76429

In the end doing the fix here would be much easier. I've tested this and it fixes the integration.

This fixes phpstorm integration, which cannot currrently correctly detect behat version because of output that's mixed with the output in this extension.
@dvdoug
Copy link
Owner

dvdoug commented Sep 22, 2024

Hi @ostrolucky

Thanks for the PR. I've also tested this and it seems to work, but before I merge/release I'd like to understand why it works/what's the theory behind the change? The getErrorOutput() method doesn't appear to have any documentation on the Symfony side (the only reference I can see in the docs is in the Process component?). It's a secret "getter" on the output stream that switches things from stdout to stderr?

@ostrolucky
Copy link
Contributor Author

Yes getErrorOutput is just a getter for output that directs to stderr

It's briefly mentioned here https://symfony.com/doc/current/components/process.html#usage, but uses long terminology ("standard output" instead of "stdout", "error output" instead of "stderr")

@dvdoug dvdoug merged commit 3adfad8 into dvdoug:master Sep 22, 2024
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants