Exclude unnecessary files from the dist files #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ostrolucky Thanks for the PR - I'm not opposed to excluding things like the tests from the dists, but I'm not sure how I feel about excluding the docs - I'm in two minds about that. I'll need to give that a think. I should be doing a new release in November for Symfony 7, so will merge+release with that if I'm going to |
|
If that makes it easier for you to decide, I am fine with excluding docs from my PR |
|
I've removed /docs from the list. I hope that makes this easier to merge for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original motivation for this PR is that our CI detects requirements.txt from our vendor folder that you are shipping and then unnecessarily runs python scanning. We can as well exclude other files.