Drop PHP 7.3

dvdoug · Nov 17, 2023 · 38cced6 · 38cced6
1 parent 5e29262
commit 38cced6
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 38 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,7 +20,6 @@ jobs:
           - "8.1"
           - "8.0"
           - "7.4"
-          - "7.3"
 
         php-code-coverage-version:
           - "^10.0"
@@ -43,14 +42,10 @@ jobs:
         exclude:
           - php-version: "7.4"
             symfony-version: "^6.0"
-          - php-version: "7.3"
-            symfony-version: "^6.0"
           - php-version: "8.0"
             php-code-coverage-version: "^10.0"
           - php-version: "7.4"
             php-code-coverage-version: "^10.0"
-          - php-version: "7.3"
-            php-code-coverage-version: "^10.0"
 
     steps:
     - uses: actions/checkout@v4

diff --git a/composer.json b/composer.json
@@ -12,7 +12,7 @@
         }
     ],
     "require": {
-        "php": "^7.3 || ^8.0",
+        "php": "^7.4 || ^8.0",
         "composer-runtime-api": "^2.0",
         "behat/behat": "^3.10",
         "composer/semver": "^3.0",

diff --git a/src/Controller/Cli/CodeCoverageController.php b/src/Controller/Cli/CodeCoverageController.php
@@ -14,16 +14,12 @@
 
 class CodeCoverageController implements Controller
 {
-    /**
-     * {@inheritdoc}
-     */
     public function configure(Command $command): void
     {
         $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip Code Coverage generation');
     }
 
     /**
-     * {@inheritdoc}
      * @codeCoverageIgnore
      */
     public function execute(InputInterface $input, OutputInterface $output): void

diff --git a/src/Extension.php b/src/Extension.php
@@ -37,16 +37,10 @@
 
 class Extension implements ExtensionInterface
 {
-    /**
-     * {@inheritdoc}
-     */
     public function initialize(ExtensionManager $extensionManager): void
     {
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function load(ContainerBuilder $container, array $config): void
     {
         $container->registerForAutoconfiguration(Controller::class)->addTag(CliExtension::CONTROLLER_TAG);
@@ -61,9 +55,6 @@ public function load(ContainerBuilder $container, array $config): void
         $container->setParameter('behat.code_coverage.config.cache', $config['cache']);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function configure(ArrayNodeDefinition $builder): void
     {
         $builder
@@ -185,17 +176,11 @@ public function configure(ArrayNodeDefinition $builder): void
         ->end();
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getConfigKey()
     {
         return 'code_coverage';
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function process(ContainerBuilder $container): void
     {
         /** @var InputInterface $input */

diff --git a/src/Service/ReportService.php b/src/Service/ReportService.php
@@ -24,10 +24,7 @@
 
 class ReportService
 {
-    /**
-     * @var array
-     */
-    private $config;
+    private array $config;
 
     /**
      * Constructor.

diff --git a/src/Subscriber/EventSubscriber.php b/src/Subscriber/EventSubscriber.php
@@ -15,17 +15,11 @@
 
 class EventSubscriber implements EventSubscriberInterface
 {
-    /**
-     * @var CodeCoverage
-     */
-    private $coverage;
+    private ?CodeCoverage $coverage;
 
-    /**
-     * @var ReportService
-     */
-    private $reportService;
+    private ReportService $reportService;
 
-    public function __construct(ReportService $reportService, CodeCoverage $coverage = null)
+    public function __construct(ReportService $reportService, ?CodeCoverage $coverage)
     {
         $this->reportService = $reportService;
         $this->coverage = $coverage;