More deterministic sorting

dvdoug · Jan 26, 2020 · a2f523d · a2f523d
1 parent f38e794
commit a2f523d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/OrientatedItemFactory.php b/src/OrientatedItemFactory.php
@@ -80,6 +80,9 @@ public function getBestOrientation(
  $orientationAMinGap = min($orientationAWidthLeft, $orientationALengthLeft);
  $orientationBMinGap = min($orientationBWidthLeft, $orientationBLengthLeft);
 
+ if ($orientationAMinGap === 0 && $orientationBMinGap === 0) {
+ return $a->getDepth() <=> $b->getDepth();
+ }
  if ($orientationAMinGap === 0) { // prefer A if it leaves no gap
  return -1;
  }

diff --git a/tests/InfalliblePackerTest.php b/tests/InfalliblePackerTest.php
@@ -452,6 +452,6 @@ public function testIssue182B(): void
  /** @var PackedBox[] $packedBoxes */
  $packedBoxes = iterator_to_array($packer->pack(), false);
 
- self::assertCount(42, $packedBoxes);
+ self::assertCount(41, $packedBoxes);
  }
 }