Compare dimensions explicitly when looking for identically sized obje…

…cts rather than relying on simple object equality. Fixes #142

src/OrientatedItemFactory.php

@@ -14,6 +14,7 @@
 use function count;
 use function min;
 use function reset;
+use function sort;
 use function usort;
 
 /**
@@ -124,8 +125,7 @@ public function getPossibleOrientations(
         $orientations = [];
 
         //Special case items that are the same as what we just packed - keep orientation
-        /* @noinspection PhpNonStrictObjectEqualityInspection */
-        if ($prevItem && $prevItem->getItem() == $item) {
+        if ($prevItem && $this->isSameDimensions($prevItem->getItem(), $item)) {
             $orientations[] = new OrientatedItem($item, $prevItem->getWidth(), $prevItem->getLength(), $prevItem->getDepth());
         } else {
 
@@ -238,4 +238,20 @@ function (OrientatedItem $orientation) {
             }
         );
     }
+
+    /**
+     * Compare two items to see if they have same dimensions
+     * @param Item $itemA
+     * @param Item $itemB
+     * @return bool
+     */
+    protected function isSameDimensions(Item $itemA, Item $itemB): bool
+    {
+        $itemADimensions = [$itemA->getWidth(), $itemA->getLength(), $itemA->getDepth()];
+        $itemBDimensions = [$itemB->getWidth(), $itemB->getLength(), $itemB->getDepth()];
+        sort($itemADimensions);
+        sort($itemBDimensions);
+
+        return $itemADimensions === $itemBDimensions;
+    }
 }

tests/Test/TestItem.php

@@ -9,6 +9,7 @@
 namespace DVDoug\BoxPacker\Test;
 
 use DVDoug\BoxPacker\Item;
+use stdClass;
 
 class TestItem implements Item
 {
@@ -42,6 +43,18 @@ class TestItem implements Item
      */
     private $keepFlat;
 
+    /**
+     * Test objects that recurse
+     * @var stdClass
+     */
+    private $a;
+
+    /**
+     * Test objects that recurse
+     * @var stdClass
+     */
+    private $b;
+
     /**
      * TestItem constructor.
      *
@@ -66,6 +79,12 @@ public function __construct(
         $this->depth = $depth;
         $this->weight = $weight;
         $this->keepFlat = $keepFlat;
+
+        $this->a = new stdClass();
+        $this->b = new stdClass();
+
+        $this->a->b = $this->b;
+        $this->b->a = $this->a;
     }
 
     /**