Reverse iterate over items when removing to take advantage of sort or…

…der. #182
dvdoug · Dec 21, 2019 · 16ff9bd · 16ff9bd
1 parent 0fef056
commit 16ff9bd
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/ItemList.php b/src/ItemList.php
@@ -66,12 +66,19 @@ public function insert(Item $item): void
      */
     public function remove(Item $item): void
     {
-        foreach ($this->list as $key => $itemToCheck) {
-            if ($itemToCheck === $item) {
-                unset($this->list[$key]);
-                break;
-            }
+        if (!$this->isSorted) {
+            usort($this->list, [$this, 'compare']);
+            $this->isSorted = true;
         }
+
+        end($this->list);
+        do {
+            if (current($this->list) === $item) {
+                unset($this->list[key($this->list)]);
+                return;
+            }
+        } while (prev($this->list) !== false);
+
     }
 
     /**