Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add javadoc about default compression threshold #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yev
Copy link

@yev yev commented Mar 23, 2014

Hi Dustin,
I was struggling about 2 days to find out the issue with compressed image content which could not be served by nginx memcached anent (broken image).

I hope this little JavaDoc will help people to manage such situations

@daschl
Copy link
Collaborator

daschl commented Jun 17, 2014

@yev thanks, we need to get this in through gerrit. Do you want to do this in your own or should I get it in and note you in the commit msg?

@yev
Copy link
Author

yev commented Jun 17, 2014

@daschl you are welcome, you have gerrit outside the github? To make it simple, just push my patch with yours :)

@daschl
Copy link
Collaborator

daschl commented Jun 17, 2014

@yev correct github is just a mirror. we use gerrit for code review. i'll push it through mine, cheers!

You can find more info here if you are curious: http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants