Discover more modules (exes, sub-libraries, test-suites) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exe Main modules are prefixed with the exe name, fixing this old graphmod bug: yav/graphmod#28
ramirez7
commented
Aug 29, 2023
| otherMod <- "Main" : buildInfo.otherModules | ||
| pure Module | ||
| { name = fromString $ | ||
| if otherMod == "Main" |
There was a problem hiding this comment.
This is kind of a dumb way to do this, but it works.
ramirez7
commented
Aug 29, 2023
| @@ -20,3 +20,7 @@ test: graphex.cabal | |||
| fmt: | |||
| fd .hs --exec stylish-haskell -i | |||
| .PHONY: fmt | |||
|
|
|||
| graph.json: | |||
| cabal run -v0 exe:graphex -- cabal > graph.json | |||
There was a problem hiding this comment.
We need -v0 due to haskell/cabal#7790
|
I want to make discovery command-line configurable + allow the user to optionally also discover external modules as well. |
The only thing left is to add to the existing |
dustin
reviewed
Sep 5, 2023
| fs <- getDirectoryContents "." -- XXX | ||
| mods <- fmap fold . traverse discoverCabalModules . filter ((".cabal" ==) . takeExtension) $ fs | ||
| mods <- fmap fold . traverse (discoverCabalModules opts) . filter ((".cabal" ==) . takeExtension) $ fs |
There was a problem hiding this comment.
I keep feeling like fmap fold . traverse should be a thing.
There was a problem hiding this comment.
It's foldMapA? But it's one pass:
foldMapA
:: forall t f a b
. Foldable t
=> Applicative f
=> Monoid b
=> (a -> f b)
-> t a
-> f b
foldMapA f = getAp . foldMap (Ap . f)Hm I should probably write a proposal to add it to base. I always write it in new projects 😆
dustin
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exe
Mainmodules are prefixed with the exe name, fixing this oldgraphmodbug: yav/graphmod#28Fixes #8