dust-hive: make restaert interactive to select env and service #20654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![dust-agent[bot]](https://avatars.githubusercontent.com/in/1117438?s=60&v=4){kind=small}
| if (serviceArg) { | ||
| // Service provided via CLI argument | ||
| if (!isServiceName(serviceArg)) { | ||
| console.log(`\nServices: ${ALL_SERVICES.join(", ")}`); |
Contributor
There was a problem hiding this comment.
[GEN8] Do not use console.log, console.error, etc. — always use the app logger
Direct calls to console.log are prohibited. Use the application logger instead:
Suggested change
| console.log(`\nServices: ${ALL_SERVICES.join(", ")}`); | |
| logger.info(`\nServices: ${ALL_SERVICES.join(", ")}`); |
Contributor
Author
There was a problem hiding this comment.
Same as before
fabiencelier
force-pushed
the
dh-restart-improve
branch
from
63e59b1 to
3ea59d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can now be use with just
dust-hive restartand select the env + service manuallyor just specify the env and select the service
or specify all like before
Tests
manual tests
Risk
low
Deploy Plan
none