fix(tests): prevent state leakage in MCP server tests #20651
+59
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that modify INTERNAL_MCP_SERVERS need to restore the original config after each test, even if assertions fail. Added afterEach cleanup and try/finally blocks to ensure global state is restored. Also exported InternalMCPServerEntryBase type for use in tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
INTERNAL_MCP_SERVERSnow restore original config even when assertions failafterEachcleanup inmcp_server_view_resource.test.tstry/finallyinindex.test.tsfor guaranteed cleanupInternalMCPServerEntryBasetype for proper typing in testsTest plan
🤖 Generated with Claude Code