Consider resources (naive approach) #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve implementation). Partially fixes duo-labs#15
…(useful in debugging or even just getting a sense of the overprovisioning)
|
Looks like we worked on a solution for this simultaneously. I'm going to close this out in favor of the one I just did, as I took conditions into consideration as well, along with creating some unit tests for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive approach to partially fix #15. It prevents incorrect removal of
allowed_actionsby only removing aDenyaction if it applies to*resources. There are problems with this approach, it's incomplete, etc. A more complete solution would be to implement #2 and cover all of the tricky inverse action/resource scenarios.