Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Return client key for ancillary component #335

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

JamesWair
Copy link
Contributor

OfferRequest will now return the client_key for use in the ancillaries component.

@JamesWair JamesWair marked this pull request as ready for review September 29, 2023 14:41
@JamesWair JamesWair requested a review from a team as a code owner September 29, 2023 14:41
Copy link
Contributor

@nlopes nlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing we shouldn't push as part of this PR. All else looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
@@ -8,15 +8,6 @@ The format is based on [Keep a Changelog] and this project adheres to [Semantic
[Semantic Versioning]: http://semver.org/spec/v2.0.0.html


## [0.6.1] - 2023-09-16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by mistake during rebase you removed this - sorry - it was part of a PR I merged only today :( I should have linked with what you were doing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I didn't notice this in resolving the conflicts, will replace

@nlopes nlopes self-requested a review October 2, 2023 11:04
Copy link
Contributor

@nlopes nlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to squash & merge 🙈

@JamesWair JamesWair merged commit c270873 into main Oct 2, 2023
14 checks passed
@JamesWair JamesWair deleted the Return-client-key-for-ancillary-component branch October 2, 2023 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants