Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <=python3.7 compatibility #53

Merged
merged 1 commit into from
May 22, 2021
Merged

Add <=python3.7 compatibility #53

merged 1 commit into from
May 22, 2021

Conversation

keyan
Copy link
Contributor

@keyan keyan commented May 10, 2021

Adds compatibility for Python versions which don't have TypedDict in the standard library via typing module. Currently this assumption causes duckietown-world to not be compatible with Colab or other environments which require Python 3.7.

This is the documented method for dealing with version differences with mypy, see docs.

Fixes #46

@keyan
Copy link
Contributor Author

keyan commented May 10, 2021

PTAL @AndreaCensi

@keyan
Copy link
Contributor Author

keyan commented May 18, 2021

cc @mostafaelaraby

@afdaniele afdaniele requested a review from AndreaCensi May 18, 2021 19:20
@AndreaCensi AndreaCensi merged commit 79d1c5b into duckietown:daffy May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypedDict error of python 3.6
2 participants