-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Streamline importing passwords from Google #6746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9bae0eb
to
3fd51e8
Compare
3fd51e8
to
e1f429e
Compare
e1f429e
to
d56fd53
Compare
ec14a05
to
68f3f84
Compare
68f3f84
to
915503e
Compare
915503e
to
5b09e5f
Compare
df35840
to
0526418
Compare
...fill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/AutofillJavascriptInterface.kt
Show resolved
Hide resolved
a8958cb
to
525d393
Compare
package.json
Outdated
"@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#dbajpeyi/log-forced-items", | ||
"@duckduckgo/content-scope-scripts": "github:duckduckgo/content-scope-scripts#pr-releases/pr-1933", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will get a stable release before we merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments around test cases and some tidy up of classes. The core part looks good.
Tested on an emulator and found some issues (will attach video on the task), on my real device worked well.
.../main/java/com/duckduckgo/autofill/impl/configuration/AutofillAvailableInputTypesProvider.kt
Show resolved
Hide resolved
.../main/java/com/duckduckgo/autofill/impl/configuration/AutofillAvailableInputTypesProvider.kt
Outdated
Show resolved
Hide resolved
.../duckduckgo/autofill/impl/importing/gpm/webflow/ImportGooglePasswordsWebFlowViewModelTest.kt
Outdated
Show resolved
Hide resolved
.../duckduckgo/autofill/impl/importing/gpm/webflow/ImportGooglePasswordsWebFlowViewModelTest.kt
Show resolved
Hide resolved
.../duckduckgo/autofill/impl/importing/gpm/webflow/ImportGooglePasswordsWebFlowViewModelTest.kt
Outdated
Show resolved
Hide resolved
.../duckduckgo/autofill/impl/importing/gpm/webflow/ImportGooglePasswordsWebFlowViewModelTest.kt
Outdated
Show resolved
Hide resolved
...fill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/AutofillJavascriptInterface.kt
Show resolved
Hide resolved
...est/java/com/duckduckgo/autofill/impl/configuration/RealAutofillRuntimeConfigProviderTest.kt
Outdated
Show resolved
Hide resolved
525d393
to
e969fd8
Compare
b412f69
to
c4c491b
Compare
We followed up on that elsewhere; issue was that the emulator was set to destroy activities as soon as you leave them. I've addressed the feedback, and made a commit setting the default value of the feature flag to be enabled. One last thing I'm waiting for before I merge is a release of |
c4c491b
to
5cfbe1d
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211197010246726?focus=true
Description
Streamlines the web flow for importing passwords from Google; when prompted for the 2nd / nth time for password re-entry these are re-authenticated automatically using autofill.
Steps to test this PR
Fresh install, manual password entry
internal
build typeAutofill Dev Settings
->Launch Google Passwords (import flow)
Immediately import again, manual password entry
Launch Google Passwords (import flow)
againUsing our autofill
View saved logins
and manually enter your Google username and password withgoogle.com
for the URLGoogle Account Logout
Autofill Dev Settings
->Launch Google Passwords (import flow)
Feature flag disabled
canReAuthenticateGoogleLoginsAutomatically
Google Account Logout
andDelete all saved logins
to clear stateLaunch Google Passwords (import flow)