Skip to content

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Sep 5, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211197010246726?focus=true

Description

Streamlines the web flow for importing passwords from Google; when prompted for the 2nd / nth time for password re-entry these are re-authenticated automatically using autofill.

Steps to test this PR

Fresh install, manual password entry

  • Fresh install from this branch as an internal build type
  • Launch Autofill Dev Settings-> Launch Google Passwords (import flow)
  • Enter your username / Google email address
  • Type your password (or copy/paste.. just don't use our autofill) and hit next button
  • Verify: automation takes over for the rest of the flow and import happens successfully

Immediately import again, manual password entry

  • Tap Launch Google Passwords (import flow) again
  • Verify: password is not automatically autofilled
  • Type your password (or copy/paste.. just don't use our autofill) and hit next button
  • Verify: automation takes over for the rest of the flow and import happens successfully (will show 0 passwords imported since they'll be duplicates)

Using our autofill

  • Tap on View saved logins and manually enter your Google username and password with google.com for the URL
  • Save and return to autofill dev settings
  • Tap on Google Account Logout
  • Launch Autofill Dev Settings-> Launch Google Passwords (import flow)
  • Choose your username (which will likely be remembered)
  • Verify you are prompted to autofill your password (and accept)
  • Verify: automation takes over for the rest of the flow and import happens successfully

Feature flag disabled

  • Launch feature flag inventory and disable canReAuthenticateGoogleLoginsAutomatically
  • Return to autofill dev settings, tap Google Account Logout and Delete all saved logins to clear state
  • Tap on Launch Google Passwords (import flow)
  • Choose your username (which will likely be remembered)
  • Type your password (or copy/paste) and hit next button
  • Verify: automation happens only up to password prompt

Copy link
Member Author

CDRussell commented Sep 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from 9bae0eb to 3fd51e8 Compare September 5, 2025 12:14
@CDRussell CDRussell changed the base branch from develop to graphite-base/6746 September 5, 2025 12:31
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from 3fd51e8 to e1f429e Compare September 5, 2025 12:31
@CDRussell CDRussell changed the base branch from graphite-base/6746 to feature/craig/streamline_password_imports_dev_settings September 5, 2025 12:32
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from e1f429e to d56fd53 Compare September 5, 2025 12:36
Base automatically changed from feature/craig/streamline_password_imports_dev_settings to develop September 5, 2025 12:53
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch 4 times, most recently from ec14a05 to 68f3f84 Compare September 9, 2025 13:38
@CDRussell CDRussell changed the base branch from develop to graphite-base/6746 September 9, 2025 15:21
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from 68f3f84 to 915503e Compare September 9, 2025 15:21
@CDRussell CDRussell changed the base branch from graphite-base/6746 to feature/craig/normalize_domain_only_for_eltdplusone September 9, 2025 15:21
@CDRussell CDRussell changed the base branch from feature/craig/normalize_domain_only_for_eltdplusone to graphite-base/6746 September 10, 2025 09:25
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from 915503e to 5b09e5f Compare September 10, 2025 09:25
@CDRussell CDRussell changed the base branch from graphite-base/6746 to develop September 10, 2025 09:26
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch 4 times, most recently from a8958cb to 525d393 Compare September 10, 2025 11:12
package.json Outdated
Comment on lines 17 to 18
"@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#dbajpeyi/log-forced-items",
"@duckduckgo/content-scope-scripts": "github:duckduckgo/content-scope-scripts#pr-releases/pr-1933",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will get a stable release before we merge

@CDRussell CDRussell marked this pull request as ready for review September 10, 2025 11:13
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments around test cases and some tidy up of classes. The core part looks good.

Tested on an emulator and found some issues (will attach video on the task), on my real device worked well.

@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from 525d393 to e969fd8 Compare September 11, 2025 09:00
@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch 2 times, most recently from b412f69 to c4c491b Compare September 11, 2025 21:59
@CDRussell
Copy link
Member Author

CDRussell commented Sep 11, 2025

Tested on an emulator and found some issues

We followed up on that elsewhere; issue was that the emulator was set to destroy activities as soon as you leave them.

I've addressed the feedback, and made a commit setting the default value of the feature flag to be enabled. One last thing I'm waiting for before I merge is a release of c-s-s library.

@CDRussell CDRussell force-pushed the feature/craig/streamline_password_imports branch from c4c491b to 5cfbe1d Compare September 12, 2025 08:21
@CDRussell CDRussell merged commit fd8f4b5 into develop Sep 12, 2025
7 checks passed
@CDRussell CDRussell deleted the feature/craig/streamline_password_imports branch September 12, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants