Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RoW subscriptions #5327

Merged
merged 20 commits into from
Dec 2, 2024
Merged

Add support for RoW subscriptions #5327

merged 20 commits into from
Dec 2, 2024

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Nov 27, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1205648422731273/1208858958261534/f

Description

See task.

Steps to test this PR

See task.

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@lmac012 Graphite App
Copy link
Contributor Author

lmac012 commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lmac012 lmac012 force-pushed the feature/lukasz/row-subscriptions branch from c9b9309 to 5b8f310 Compare November 27, 2024 16:08
@lmac012 lmac012 marked this pull request as ready for review November 28, 2024 08:57
@lmac012 lmac012 force-pushed the feature/lukasz/row-subscriptions branch 2 times, most recently from 72abc32 to 8230ccf Compare November 28, 2024 18:57
@lmac012
update copy
94fcebf
@lmac012
add isLaunchedROW FF
83f550f
@lmac012
remove unused method
8e8521e
@lmac012
rename plan id constants to indicate region
968d4f5
@lmac012
add /features endpoint to SubscriptionsService
2f79768
@lmac012
move control over available features into SubscriptionManager
0a8dcd3
@lmac012
implement storage for subscription features
5c438e9
@lmac012
fetch and store subscription features when products are available
07b0921
@lmac012
use subscription features fetched from BE instead of hardcoded values
59672f9
@lmac012
handle FE callbacks that use updated feature values
158fea1
@lmac012
enable purchasing RoW subscription
f5ea784
@lmac012
update copy in app settings
c63bb30
@lmac012
hide PIR feedback category for non-US subscription
6d56dd6
@lmac012
fix typo
94c1942
@lmac012
move accessing shared prefs to io dispatcher
64ca81c
@lmac012
extract hardcoded strings to string resources file
607e25a
@lmac012
extract method
5b3f819
@lmac012 lmac012 force-pushed the feature/lukasz/row-subscriptions branch 2 times, most recently from d04a296 to 33b70b1 Compare December 2, 2024 08:15
@lmac012 lmac012 force-pushed the feature/lukasz/row-subscriptions branch from 33b70b1 to 79f887e Compare December 2, 2024 09:14
karlenDimla
karlenDimla approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@karlenDimla karlenDimla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected. Found one edge case (will outline in task). Not sure how possible that is to do in real life.

@lmac012 lmac012 merged commit 8ebd7d8 into develop Dec 2, 2024
8 checks passed
@lmac012 lmac012 deleted the feature/lukasz/row-subscriptions branch December 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlenDimla karlenDimla karlenDimla approved these changes

Assignees

@karlenDimla karlenDimla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmac012 @karlenDimla