Support the PostgreSQL domain #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Jan 14, 2025
JelteF
reviewed
Jan 14, 2025
test/regression/sql/domain.sql
Outdated
Comment on lines
1
to
4
| create domain domainvarchar varchar(5); | ||
| create domain domainnumeric numeric(8,2); | ||
| create domain domainint4 int4; | ||
| create domain domaintext text; |
There was a problem hiding this comment.
Domains are often use to encode check constraints:
> CREATE DOMAIN positiveint int CHECK(VALUE > 0);
CREATE DOMAIN
> select 5::positiveint;
positiveint
─────────────
5
> select (-5)::positiveint;
ERROR: 23514: value for domain positiveint violates check constraint "positiveint_check"
SCHEMA NAME: public
DATATYPE NAME: positiveint
CONSTRAINT NAME: positiveint_check
In the tests for this PR you don't use that feature. I'm also not sure if/how we can implement those checks. How about for this first version we error of the domain has a constraint? (and show that we do that with a test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the domain refers to a base type, we only need to obtain the corresponding base type.
If domain refers to an array type, we need to obtain the corresponding array type and array dimension information.
If the type currently used is an array type, and the member type of the array type is domain, we need to get the most basic type and then construct the corresponding array type.
#514